-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rule type #119
refactor: rule type #119
Conversation
MMh, in local I don't have problems with the test with race command, do you have any idea on where it could come from and how could I fix it @notJoon ? |
It seems a race condition occurred in the The simplest solution would be to remove |
hey, this changes seems good. are you ready for review? or still need some changes? |
I am ready for a review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merged. Thanks 👍
fixed #92
This PR propose a new simpler implementation of LintRule to create a new rule easier than before.
ps: be harsh with the PR to have some good foundations to build upon