inline source when srcdir contains white-spaces #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praiskup
force-pushed
the
white-spaces
branch
2 times, most recently
from
cf8a7b1
to
c538d8b
Compare
Add new syntax for source inline:
# set '$inline_source_dir' to `dirname "$0"/`
inline_source_dir=`echo "$0" |${SED-sed} 's|[^/]*$||'`
. "$inline_source_dir"/sourced-file
This version avoids "`"sth"`" like commands (nested quotes), while
we are now able to use inline-source script within directory
which pathname contains spaces. As a side effect, we save some
fork() calls because the directory is constructed only once.
Related to github issue gnulib-modules#6.
* build-aux/inline-source: Move ourself to the new syntax,
document new syntax.
(func_include): Parse the new syntax, quote $progpath properly.
* build-aux/bootstrap.in: Use new syntax.
* bootstrap: Sync with new sources.
praiskup
force-pushed
the
white-spaces
branch
from
c538d8b
to
83e6857
Compare
|
@sshambar, the reasoning behind this pull request is that your pull request uses the nested double-quotes interleaved with nested command, which is not that portable. On the other hand, your version will probably work most of the time -> so it would on user's consideration to pick the portable-enough version.... so I wouldn't be against adding both of the new include syntaxes. Also, there are still some nits in this pull-request compared to yours, so I am curious whether you would find some time to add the 'inline_source_dir' approach into your pull-request, and switching the I'm very sorry for the delay, btw. |
praiskup
added a commit
that referenced
this pull request
Apr 24, 2017
Fixes github issue #8. Thanks to Reuben Thomas. * README.md: s/let it initialized/let it be initialized/.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please @gvvaughan and @sshambar, can you have a look?