line_chart: Fix Boundary Gap Default when new StackSeries option is e…

…nabled

bar_chart.go

@@ -118,8 +118,6 @@ func (b *barChart) render(result *defaultRenderResult, seriesList SeriesList) (B
 	seriesNames := seriesList.Names()
 	divideValues := xRange.AutoDivide()
 	stackedSeries := flagIs(true, opt.StackSeries)
-
-	// Basic margins around each bar or bar cluster
 	var margin, barMargin, barWidth int
 	var accumulatedHeights []int // prior heights for stacking to avoid recalculating the heights
 	if stackedSeries {

line_chart.go

@@ -84,7 +84,9 @@ func (l *lineChart) render(result *defaultRenderResult, seriesList SeriesList) (
 	opt := l.opt
 	seriesPainter := result.seriesPainter
 
-	boundaryGap := !opt.FillArea // boundary gap default enabled unless fill area is set
+	stackedSeries := flagIs(true, opt.StackSeries)
+	fillArea := stackedSeries || opt.FillArea // fill area defaults to on if the series is stacked
+	boundaryGap := !fillArea                  // boundary gap default enabled unless fill area is set
 	if opt.XAxis.BoundaryGap != nil {
 		boundaryGap = *opt.XAxis.BoundaryGap
 	}
@@ -99,36 +101,23 @@ func (l *lineChart) render(result *defaultRenderResult, seriesList SeriesList) (
 	}
 	xDivideValues := autoDivide(seriesPainter.Width(), xDivideCount)
 	xValues := make([]int, len(xDivideValues)-1)
+	dataCount := seriesList.getMaxDataCount(ChartTypeLine)
 	// accumulatedValues is used for stacking: it holds the summed data values at each X index
 	var accumulatedValues []float64
+	if stackedSeries {
+		accumulatedValues = make([]float64, dataCount)
+	}
 	if boundaryGap {
 		for i := 0; i < len(xDivideValues)-1; i++ {
 			xValues[i] = (xDivideValues[i] + xDivideValues[i+1]) >> 1
 		}
 	} else {
 		xValues = xDivideValues
 	}
-
-	// render list must start with the markPointPainter, as it can influence label painters (if enabled)
-	markPointPainter := newMarkPointPainter(seriesPainter)
-	markLinePainter := newMarkLinePainter(seriesPainter)
-	rendererList := []renderer{
-		markPointPainter,
-		markLinePainter,
-	}
-
 	strokeWidth := opt.LineStrokeWidth
 	if strokeWidth == 0 {
 		strokeWidth = defaultStrokeWidth
 	}
-
-	dataCount := seriesList.getMaxDataCount(ChartTypeLine)
-
-	stackedSeries := flagIs(true, opt.StackSeries)
-	if stackedSeries {
-		accumulatedValues = make([]float64, dataCount)
-	}
-
 	showSymbol := dataCount < showSymbolDefaultThreshold // default enable when data count is reasonable
 	if opt.StrokeSmoothingTension > 0 {
 		showSymbol = false // default disable symbols on curved lines since the dots won't hit the line exactly
@@ -137,6 +126,11 @@ func (l *lineChart) render(result *defaultRenderResult, seriesList SeriesList) (
 		showSymbol = *opt.SymbolShow
 	}
 
+	// render list must start with the markPointPainter, as it can influence label painters (if enabled)
+	markPointPainter := newMarkPointPainter(seriesPainter)
+	markLinePainter := newMarkLinePainter(seriesPainter)
+	rendererList := []renderer{markPointPainter, markLinePainter}
+
 	seriesCount := len(seriesList)
 	seriesNames := seriesList.Names()
 	var priorSeriesPoints []Point
@@ -178,7 +172,7 @@ func (l *lineChart) render(result *defaultRenderResult, seriesList SeriesList) (
 			}
 		}
 
-		if stackedSeries || opt.FillArea {
+		if fillArea {
 			areaPoints := make([]Point, len(points))
 			copy(areaPoints, points)
 			bottomY := yRange.getRestHeight(yRange.min)
@@ -293,7 +287,8 @@ func (l *lineChart) Render() (Box, error) {
 	}
 	// boundary gap default must be set here as it's used by the x-axis as well
 	if opt.XAxis.BoundaryGap == nil {
-		boundaryGap := !opt.FillArea // boundary gap default enabled unless fill area is set
+		fillArea := flagIs(true, opt.StackSeries) || opt.FillArea
+		boundaryGap := !fillArea // boundary gap default enabled unless fill area is set
 		l.opt.XAxis.BoundaryGap = &boundaryGap
 	}
 

line_chart_test.go

@@ -129,6 +129,7 @@ func makeFullLineChartStackedOption() LineChartOption {
 			Data: []string{
 				"1", "2", "3", "4", "5", "6", "7", "8",
 			},
+			BoundaryGap: True(),
 		},
 		Legend: LegendOption{
 			Data: dataLabels,