enable passing custom logger #5

LukasJenicek · 2024-04-02T15:17:04Z

Provide a way how to pass custom logger to keep structured logging in your application same

VojtechVitek · 2024-06-06T13:18:39Z

logRequests.go

+func LogRequests(logger Logger) func(http.RoundTripper) http.RoundTripper {
+	if logger == nil {
+		logger = &DefaultLogger{}
+	}
+
+	return func(next http.RoundTripper) http.RoundTripper {
+		return RoundTripFunc(func(req *http.Request) (resp *http.Response, err error) {
+			r := cloneRequest(req)
+
+			curlCommand, _ := http2curl.GetCurlCommand(r)
+			logger.Info("%v", curlCommand)
+			logger.Info("request: %s %s", r.Method, r.URL)
+
+			startTime := time.Now()
+			defer func() {
+				if resp != nil {
+					logger.Info("response (HTTP %v): %v %s", time.Since(startTime), resp.Status, r.URL)
+				} else {
+					logger.Info("response (<nil>): %v %s", time.Since(startTime), r.URL)
+				}
+			}()
+
+			return next.RoundTrip(r)
+		})
+	}
 }


I like this.. however instead of Logger can we just use io.Writer?

I found myself needing this, so I could save each request to a buffer and only log/print it on error :)

I totally forgot that I created this PR and today I created similar PR just week after :D It's the heat I guess..

Anyway what do you think about this approach: #7 ???

This way the consumer of the package can do whatever he likes

enable passing custom logger

438c87a

LukasJenicek force-pushed the pass_custom_logger branch from 257cb37 to 438c87a Compare April 2, 2024 15:18

VojtechVitek requested changes Jun 6, 2024

View reviewed changes

LukasJenicek closed this Jul 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

enable passing custom logger #5

enable passing custom logger #5

LukasJenicek commented Apr 2, 2024 •

edited

Loading

VojtechVitek Jun 6, 2024

LukasJenicek Jul 10, 2024

enable passing custom logger #5

enable passing custom logger #5

Conversation

LukasJenicek commented Apr 2, 2024 • edited Loading

VojtechVitek Jun 6, 2024

Choose a reason for hiding this comment

LukasJenicek Jul 10, 2024

Choose a reason for hiding this comment

LukasJenicek commented Apr 2, 2024 •

edited

Loading