Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty path in request-target #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anbraten
Copy link

@anbraten anbraten commented May 14, 2022

If the path of the url is currently empty `` instead of / the signing fails.

From RFC7540 Section 8.1.2.3:

This pseudo-header field MUST NOT be empty for "http" or "https"
URIs; "http" or "https" URIs that do not contain a path component
MUST include a value of '/'. The exception to this rule is an
OPTIONS request for an "http" or "https" URI that does not include
a path component; these MUST include a ":path" pseudo-header field
with a value of '*' (see [RFC7230], Section 5.3.4).

In addition I have added the (request-target) data to the actual headers when requested by the user.

@6543
Copy link

6543 commented Aug 18, 2023

@cjslep is this lib still maintained ?

ref: woodpecker-ci/example-config-service#10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants