Add basic auth support to rss/atom feeds

[misthios]

Allows RSS readers to access private feeds using their basic auth capabilities. Not all clients feature the ability to add cookies or headers.

fixes #32458

Tested with miniflux

no credentials:

basic auth entered:

[silverwind]

See above

[wxiaoguang]

Should match extensions case-insensitively, strings.HasSuffix is case-sensitive.

I think a small regex like regexp.MustCompile("(?i)\.(rss|atom)") is justified, cached in a top-level variable in the file.

No, it shouldn't.

[silverwind]

Should match extensions case-insensitively, strings.HasSuffix is case-sensitive.
I think a small regex like regexp.MustCompile("(?i)\.(rss|atom)") is justified, cached in a top-level variable in the file.

No, it shouldn't.

Filenames are case-insensitive, so you don't want to handle .RSS files?

[wxiaoguang]

Should match extensions case-insensitively, strings.HasSuffix is case-sensitive.
I think a small regex like regexp.MustCompile("(?i)\.(rss|atom)") is justified, cached in a top-level variable in the file.

No, it shouldn't.

Filenames are case-insensitive, so you don't want to handle .RSS files?

No, filenames are case-sensitive in many systems.

And here, it is even NOT for "filename".

[silverwind]

Ah right, I forgot we are not actually reading any FS, but generating on the fly.

I guess the routes could still be made case-insensitive to follow FS semantics and general HTTP best practices for "files", but it's not a issue with this PR.

[wxiaoguang]

Ah right, I forgot we are not actually reading any FS, but generating on the fly.

I guess the routes could still be made case-insensitive to follow FS semantics and general HTTP best practices for "files", but it's not a issue with this PR.

Actually no, I will prepare some other improvements first to clarify the problem (#33371 (comment))

[wxiaoguang]

Made some improvements in a37aea6 and added some tests