Add tests for webhook and fix some webhook bugs #33396
Merged
+630
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XL
github-actions
bot
added
modifies/api
lunny
force-pushed
the
lunny/add_webhook_test
branch
from
e4e8f89 to
f0142d0
Compare
lunny
force-pushed
the
lunny/add_webhook_test
branch
from
f0142d0 to
3df8656
Compare
silverwind
approved these changes
Jan 28, 2025
GiteaBot
added
lgtm/need 1
hiifong
approved these changes
Jan 30, 2025
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
hiifong
approved these changes
Jan 30, 2025
GiteaBot
removed
the
reviewed/wait-merge
|
I was unable to create a backport for 1.23. @lunny, please send one manually. 🍵 |
GiteaBot
added
the
backport/manual
lunny
added a commit
to lunny/gitea
that referenced
this pull request
Jan 30, 2025
This PR created a mock webhook server in the tests and added integration tests for generic webhooks. It also fixes bugs in package webhooks and pull request comment webhooks.
lunny
added a commit
to lunny/gitea
that referenced
this pull request
Jan 30, 2025
This PR created a mock webhook server in the tests and added integration tests for generic webhooks. It also fixes bugs in package webhooks and pull request comment webhooks.
lunny
added a commit
that referenced
this pull request
Feb 2, 2025
This PR created a mock webhook server in the tests and added integration tests for generic webhooks. It also fixes bugs in package webhooks and pull request comment webhooks. This also corrected an error on the package webhook. The previous implementation uses a `User` struct as an organization, now it has been corrected but it will not be consistent with the previous implementation, some fields which not belong to the organization have been removed. Backport #33396 Backport part of #33337
lunny
added a commit
to lunny/gitea
that referenced
this pull request
Feb 4, 2025
Fix go-gitea#32873 Fix go-gitea#33201 ~Fix go-gitea#33244~ ~Fix go-gitea#33302~ depends on ~go-gitea#33396~ A part of this PR should be backported to v1.23 manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR created a mock webhook server in the tests and added integration tests for generic webhooks.
It also fixes bugs in package webhooks and pull request comment webhooks.