customize the time param format in SQL log #6508
Conversation
Co-authored-by: Gabriel Aquino Oliveira <[email protected]>
|
Please resolve the conflict. |
| tmFmtWithMS = "2006-01-02 15:04:05.999" | ||
| tmFmtZero = "0000-00-00 00:00:00" | ||
| nullStr = "NULL" | ||
| tmFmtZero = "0000-00-00 00:00:00" |
There was a problem hiding this comment.
What do you think about using the same tmFmtZero and TimeParamFormat format? IMO This would make confusion later if the TimeParamFormat is not used for zero values.
There was a problem hiding this comment.
What do you think about using the same tmFmtZero and TimeParamFormat format? IMO This would make confusion later if the TimeParamFormat is not used for zero values.
@saeidee
Thank you for your comment. I have considered your suggestion, but using the same TimeParamFormat for zero time values would lead to a breaking change, so I have maintained the current behavior for now.
before: 0000-00-00 00:00:00
after: 0001-01-01 00:00:00
|
Use a global variable to customize time format sounds tricky ;( Maybe we need to figure out another solution... |
Thanks for your feedback. I agree that using a global variable is a quick but inelegant solution. If you have any alternative agree in mind, pls let me know and I want to improve this implementation. |
What did this pull request do?
Add feature to allow customization of the time parameter format in the SQL log.
User Case Description