fix: unsupported data on nested joins with preloads
#6957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @N-Schaef Can you add some test cases to make sure it works? Thank you. |
|
Hello @jinzhu, sorry for the late reply. I've been on vacation. I have added a test-case that results in the error on the main branch but works with the changes. But somehow an (in my opinion) unrelated error now fails on the mysql:latest. |
|
Is there anything left to do? |
a631807682
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
This PR fixes issue #6956.
It adds
reflect.Pointeras an valid reflect target for preloads.This seems to be required for preloads of nested optional joins with preload targets.
I am not 100% sure of the broader implications of this change. But the implementation before #6877 also allowed this usecase.
User Case Description
We have complex queries with nested joins and preloads that worked on version 1.25.5 but do not work with the current version.