fix: AfterQuery should clear FROM Clause's Joins rather than the Stat… #7027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhowmik-abhijeet
pushed a commit
to bhowmik-abhijeet/gorm
that referenced
this pull request
Aug 9, 2024
…oin added as part of go-gorm#7027
3 tasks
bhowmik-abhijeet
pushed a commit
to bhowmik-abhijeet/gorm
that referenced
this pull request
Aug 11, 2024
…oin added as part of go-gorm#7027
bhowmik-abhijeet
pushed a commit
to bhowmik-abhijeet/gorm
that referenced
this pull request
Aug 11, 2024
…oin added as part of go-gorm#7027
3 tasks
jinzhu
pushed a commit
that referenced
this pull request
Aug 22, 2024
…oin added as part of #7027 (#7153) Co-authored-by: Abhijeet Bhowmik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
fix #7025
User Case Description
There are two options. The first is to choose to clear the Joins in the fromClause each time and regenerate them for every query, which would be somewhat less performant. The second option involves adding cached fields within the fromClause's Joins, allowing subsequent queries to utilize these caches. In this case, the first option has been selected.
Of course, there is still room for optimization here.