Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(finisher_api): add Exists method #7216

Closed
wants to merge 1 commit into from
Closed

feature(finisher_api): add Exists method #7216

wants to merge 1 commit into from

Conversation

demoManito
Copy link
Member

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

User Case Description

@demoManito demoManito changed the title feature: add exists method feature(finisher_api): add exists method Oct 10, 2024
@demoManito demoManito changed the title feature(finisher_api): add exists method feature(finisher_api): add Exists method Oct 10, 2024
@demoManito
Copy link
Member Author

demoManito commented Oct 10, 2024

Hi, can I add this method? If so, is it reasonable to add it this way, or should it be placed in the driver? @jinzhu

@jinzhu
Copy link
Member

jinzhu commented Nov 14, 2024

Maybe we should place it in a helper package, keeping GORM itself clean and avoiding adding too much API directly.

@jinzhu jinzhu closed this Nov 14, 2024
@demoManito
Copy link
Member Author

Maybe we should place it in a helper package, keeping GORM itself clean and avoiding adding too much API directly.

Do you mean the helper package under the go-gorm organization? @jinzhu

@jinzhu
Copy link
Member

jinzhu commented Nov 14, 2024

For now, we probably won’t maintain an additional helper package. It could be placed in a separate third-party library for the time being.

@jinzhu jinzhu deleted the exists branch November 14, 2024 10:58
@demoManito
Copy link
Member Author

For now, we probably won’t maintain an additional helper package. It could be placed in a separate third-party library for the time being.

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants