Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change DefaultValueValue to the same as other drivers #222

Merged
merged 1 commit into from
Oct 26, 2023
Merged

fix: change DefaultValueValue to the same as other drivers #222

merged 1 commit into from
Oct 26, 2023

Conversation

MrChaos1993
Copy link
Contributor

@MrChaos1993 MrChaos1993 commented Oct 13, 2023

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

Same behavior as in other drivers.

https://github.com/go-gorm/mysql/blob/master/migrator.go#L296
https://github.com/go-gorm/sqlite/blob/master/ddlmod.go#L146

relation to go-gorm/gorm#6579

discussion: #211 (comment)

User Case Description

@black-06
Copy link
Contributor

Let's merge it

@jinzhu jinzhu merged commit 7630365 into go-gorm:master Oct 26, 2023
1 check passed
PuneetPunamiya pushed a commit to PuneetPunamiya/postgres that referenced this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants