feat(recovery): Add recovery (#26)

go-kratos-ecosystem · Oct 31, 2023 · 2d525ad · 2d525ad
1 parent 4dceb84
commit 2d525ad
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/recovery/recovery.go b/recovery/recovery.go
@@ -34,7 +34,7 @@ func New(opts ...Option) *Recovery {
 	}
 }
 
-func (r *Recovery) Wrap(f func() error) error {
+func (r *Recovery) Wrap(f func()) {
 	defer func() {
 		if err := recover(); err != nil {
 			if r.opt.handler != nil {
@@ -43,5 +43,5 @@ func (r *Recovery) Wrap(f func() error) error {
 		}
 	}()
 
-	return f()
+	f()
 }
diff --git a/recovery/recovery_test.go b/recovery/recovery_test.go
@@ -7,22 +7,22 @@ import (
 )
 
 func TestRecovery_Wrap(t *testing.T) {
-	fn := func() error {
+	fn := func() {
 		panic("test")
-
-		return nil
 	}
 
 	// default
 	r := New()
 	assert.Panics(t, func() {
-		_ = r.Wrap(fn)
+		r.Wrap(fn)
 	})
 
 	// with handler
 	r = New(WithHandler(func(err interface{}) {
 		assert.Equal(t, "test", err)
 	}))
 
-	assert.NoError(t, r.Wrap(fn))
+	assert.NotPanics(t, func() {
+		r.Wrap(fn)
+	})
 }