Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update session.go add InstantEnsureIndex #446

Open
wants to merge 1 commit into
base: v2
Choose a base branch
from
Open

Update session.go add InstantEnsureIndex #446

wants to merge 1 commit into from

Conversation

sulthonzh
Copy link

InstantEnsureIndex

vivace-io
vivace-io reviewed Jul 19, 2017
View reviewed changes
session.go

for k, v := range indexMap {
fields := strings.Split(k, "_")
index := mgo.Index{}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This call to package mgo is failing the build. Type Index already exists in the same package.

@vivace-io
Copy link

Naming feels rather confusing, doesn't seem to accurately describe what the function does. Might want to consider another name?

@vivace-io vivace-io mentioned this pull request Jul 19, 2017
Open
@hexadecy
Copy link

I suggest EnsureIndexFromStruct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivace-io vivace-io vivace-io left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sulthonzh @vivace-io @hexadecy