Slippy tile issue 997 #1007
Merged
Slippy tile issue 997 #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARolek
approved these changes
Jul 31, 2024
| @@ -79,7 +79,7 @@ func TestReplaceTokens(t *testing.T) { | |||
| sql: "SELECT id, !pixel_width! as width, !pixel_height! as height, !scale_denominator! as scale_denom FROM foo WHERE !BBOX!", | |||
| layer: Layer{srid: tegola.WebMercator, geomField: "geom"}, | |||
| tile: provider.NewTile(11, 1070, 676, 64, tegola.WebMercator), | |||
| expected: `SELECT id, 76.43702827 as width, 76.43702827 as height, 272989.38669477 as scale_denom FROM foo WHERE "geom".ST_IntersectsRectPlanar(NEW ST_POINT($1, $3), NEW ST_POINT($2, $3)) = 1`, | |||
| expected: `SELECT id, 76.43702829 as width, 76.43702829 as height, 272989.38673277 as scale_denom FROM foo WHERE "geom".ST_IntersectsRectPlanar(NEW ST_POINT($1, $3), NEW ST_POINT($2, $3)) = 1`, | |||
There was a problem hiding this comment.
Are these the old values before the change happened in the last version, or did you generate new values?
There was a problem hiding this comment.
I generated new values. Did not conform the values.
There was a problem hiding this comment.
Ok, maybe check the old values to see how close they line up.
There was a problem hiding this comment.
I looked at it's all within 0.00000001 of each other. Some of the number are close to what was there, but the numbers after are different. I think this is again due to the drift in floating numbers.
ARolek
reviewed
Jul 31, 2024
gdey
force-pushed
the
slippy_tile_issue_997
branch
from
622dd46
to
743a4d8
Compare
Pull Request Test Coverage Report for Build e5a736695Details
💛 - Coveralls |
|
@gdey one nit on this PR, can you rename the commit titles? They're currently the same, but one commit is for vendoring the geom package, the other is for adopting it. |
updated geom to v0.1.0
Updated to use slippy tile from geom v0.1.0. This fixes the issues with slippy tile.
gdey
force-pushed
the
slippy_tile_issue_997
branch
from
743a4d8
to
e5a7366
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.