fix: fix slice init length #1008
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree, good catch! |
ARolek
approved these changes
Oct 4, 2024
|
Looks like govulncheck is failing. I'm going to upgrade Go in a separate PR and then you can rebase to get the CI to pass. |
|
@cuishuang please rebase this branch against master |
Updated. Please review again. |
Pull Request Test Coverage Report for Build 49730d774-PR-1008Details
💛 - Coveralls |
|
This has been merged into master: 0f3131f Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention here should be to initialize a slice with a capacity of
len(observers)rather than initializing the length of this slice.The online demo: https://go.dev/play/p/q1BcVCmvidW