[fontmap] update Replacer for string normalization by handling null byte removal #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akiyosi
requested review from
whereswaldon,
benoitkugler and
andydotxyz
as code owners
|
Hmmm, since the test is failing, would it be better to normalize the footprint.Family in FindSystemFont(). 🤔 |
|
Hi, It seems indeed reasonnable to ignore termination bytes when comparing family names. Thank you for adressing that point. I'm not entirely sure how to do so, I need to think about your fix a bit deeper first. Regarding the tests, could you rather add new ones ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have confirmed that the deserialized font family name contains
\x00(e.g. MS Gothic).This is why there is a problem with fontmap.FindSystemFonts() not matching even though the correct font name is specified.
This PR is one idea to address this problem, but where to put the normalization process may be debatable.