Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing in an OTel resource as an option to clue.NewConfig #402

Merged
merged 2 commits into from
May 15, 2024

Conversation

douglaswth
Copy link
Member

No description provided.

@douglaswth douglaswth requested a review from raphael April 10, 2024 19:16
@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 93.85%. Comparing base (0240cb3) to head (cfd79c8).
Report is 2 commits behind head on main.

Files Patch % Lines
clue/config.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #402      +/-   ##
==========================================
- Coverage   93.96%   93.85%   -0.11%     
==========================================
  Files          32       32              
  Lines        1590     1596       +6     
==========================================
+ Hits         1494     1498       +4     
- Misses         73       74       +1     
- Partials       23       24       +1     
Flag Coverage Δ
micro 93.85% <66.66%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

clue/config.go Outdated Show resolved Hide resolved
@douglaswth douglaswth requested a review from raphael April 18, 2024 21:32
@raphael raphael merged commit 14b277e into main May 15, 2024
4 of 6 checks passed
@raphael raphael deleted the douglaswth/add-with-resource-for-otel-config branch May 15, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants