Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for expr.Container(s) #7

Merged
merged 4 commits into from
Nov 1, 2020
Merged

Add tests for expr.Container(s) #7

merged 4 commits into from
Nov 1, 2020

Conversation

tchssk
Copy link
Member

@tchssk tchssk commented Sep 21, 2020

#2

@tchssk
Copy link
Member Author

tchssk commented Sep 21, 2020

Is Container.AddComponent() under construction?

  • Description (and Technology) looks overriding by Container's one.
  • URL's override is missing.

@raphael
Copy link
Member

raphael commented Nov 1, 2020

Thank you! and yes you are correct the method wasn't finished and neither was AddContainer on SoftwareSystem. Thank you for pointing this out :)

@raphael raphael merged commit 246eebf into goadesign:master Nov 1, 2020
@tchssk tchssk deleted the expr-container-test branch November 2, 2020 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tchssk @raphael