Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InventoryWidget #2097

Merged
merged 5 commits into from
Nov 17, 2024
Merged

Conversation

Haselnussbomber
Copy link
Contributor

I thought it may be useful to have a widget showing Inventory containers and their items.

Screenshot1

Collectables:
Screenshot2

High Quality:
Screenshot3

@Haselnussbomber Haselnussbomber requested a review from a team as a code owner November 16, 2024 23:29
- Use GameInventoryItem.GetReadOnlySpanOfInventory
- Display Stains
- Display Materia
@Haselnussbomber
Copy link
Contributor Author

Updated to use GameInventoryItem.GetReadOnlySpanOfInventory.
Also now displays Stains and Materia if the item supports them.

Screenshot

@KazWolfe KazWolfe enabled auto-merge (squash) November 17, 2024 01:50
Copy link
Member

@KazWolfe KazWolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved if only I want a reason to check item IDs without Simple Tweaks.

@KazWolfe KazWolfe merged commit 52e8fca into goatcorp:master Nov 17, 2024
3 checks passed
@Haselnussbomber
Copy link
Contributor Author

It's not about you, it's about bringing popular debug features from a plugin into Dalamud, because said plugin might be down when we want to fix CS and Dalamud. But thanks for approving.

@KazWolfe
Copy link
Member

That was indeed the point.

@Haselnussbomber Haselnussbomber deleted the inventorywidget branch November 17, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants