Skip to content
This repository has been archived by the owner on Aug 9, 2023. It is now read-only.

[Testing] Added RaidBuffTracker #2749

Open
wants to merge 1 commit into
base: api6
Choose a base branch
from
Open

[Testing] Added RaidBuffTracker #2749

wants to merge 1 commit into from

Conversation

shdwp
Copy link
Contributor

@shdwp shdwp commented Jul 10, 2022

Adds a widget keeping track of your party abilities cooldown and state, this includes raid buffs, utility and other stuff you might be interested in.

Plugin shows when abilities are active, and where their cooldown is at, helping you to align your burst windows or figure out if you need to use the abilities.

Development: shdwp; advisor and UX: Theihe.

@karashiiro
Copy link
Contributor

Code LGTM

@karashiiro karashiiro added the code reviewed New plugin code review has been completed label Jul 19, 2022
@slotthhy
Copy link
Contributor

The json inside the latest.zip file is broken.

@shdwp
Copy link
Contributor Author

shdwp commented Aug 11, 2022

Everything has been fixed. Should be good to merge now.

@reiichi001
Copy link
Contributor

Upon install to devplugins for testing, this plugin started identifying itself as Sample Plugin and the manifest file adjusted to that.

Please update https://github.com/shdwp/xivRaidBuffTracker/blob/main/RaidBuffTracker/Plugin.cs#L10 and repackage. Otherwise, this looks ready to merge pending final decision from the plugin review team.

If possible, please also submit it to https://github.com/goatcorp/DalamudPluginsD17, going forward. While plugins that existed up until the build system was replaced are being allowed some time to switch over, tentatively until 6.3, all new plugins will be required to use the build system and it will be the primary method of submitting plugins for 6.2 compatibility (when we also switch to .Net 6, barring any major blocking issues that haven't already been fixed).

@shdwp
Copy link
Contributor Author

shdwp commented Aug 21, 2022

Fixed. And yeah if this gets approved I'll move to the new build system and stuff.

@philpax
Copy link
Contributor

philpax commented Aug 23, 2022

You're good to go - can you move it over to the new build system?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
code reviewed New plugin code review has been completed new plugin Requires a full review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants