Add RawDX12Scene #12
Draft
Add RawDX12Scene #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
RawDX12Scene.CaptureScreenshotGoes along with goatcorp/gc-cimgui#1, implements a
RawDX12Scenebased on the API ofRawDX11Scenewith some added requirements:IDXGISwapChainplus theID3D12CommandQueuethat was used to create it must be provided to make the scene.RawDX12Scene.OnPostResizemust be called within or after resizing buffers to initialize the render target views.RawDX12Scene.OnPostPresentmust be called after the original swapchain present function has been called for GPU synchronization.Other than that, it's practically a drop-in replacement for
RawDX11Sceneas far as I know. I'm not a DirectX12 master by any means so the implementation is probably sub-optimal and has some bugs but it seems to work fine inside Kingdom Hearts II from what I've tested (screenshot below of Dalamud working within KH2). Hope this helps when XIV patch 7.0 drops!NOTE:
In my current implementation clearing stacks and destroying the ImGui context are currently disabled due to crashing from ImGui trying to free bad pointers. If I understand correctly the former is used for error recovery inside Dalamud, so if I managed to do something wrong when buildingRe-enabled after discussion with @goaaats. Also I'm not 100% sure if multiple fonts will work but with Dalamud's alone it seems fine.gc-imguiand there is a way to make it work properly please let me know.