Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve network targets #404

Merged
merged 12 commits into from
Feb 12, 2024
Merged

improve network targets #404

merged 12 commits into from
Feb 12, 2024

Conversation

goatshriek
Copy link
Owner

Makes improvements focused on network targets, including:

WSAStartup and WSACleanup are now only called the first time needed and upon stumpless_free_all, respectively, instead of once for each network target opened/closed.

TCP network targets using the sys/socket.h implementation will detect a FIN message before a send and fail immediately. Before this change, the closure of the stream was not caught noticed and message sends would return with a success code despite not having being received by the remote end. TCP network targets using the Winsock implementation still exhibit the later (broken) behavior.

@goatshriek goatshriek added bug something is broken or missing enhancement new features or improvements labels Feb 5, 2024
@goatshriek goatshriek self-assigned this Feb 5, 2024
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (latest@8f3d535). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff            @@
##             latest     #404   +/-   ##
=========================================
  Coverage          ?   90.54%           
=========================================
  Files             ?       46           
  Lines             ?     4188           
  Branches          ?      556           
=========================================
  Hits              ?     3792           
  Misses            ?      273           
  Partials          ?      123           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@goatshriek goatshriek merged commit 2e8d0b6 into latest Feb 12, 2024
81 checks passed
@goatshriek goatshriek deleted the network-error branch February 12, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something is broken or missing enhancement new features or improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant