add benchmark for stumpless_get_prival_string #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds benchmarking for the function stumpless_get_prival_string.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## latest #432 +/- ##
==========================================
- Coverage 90.85% 90.62% -0.23%
==========================================
Files 47 47
Lines 4384 4384
Branches 586 586
==========================================
- Hits 3983 3973 -10
- Misses 269 278 +9
- Partials 132 133 +1 ☔ View full report in Codecov by Sentry. |
goatshriek
requested changes
Jul 30, 2024
There was a problem hiding this comment.
Thanks for putting this together! I believe two changes will be enough for this to be accepted: moving free as noted below, and adding the header for free as well.
I'm unsure why the locale CI builds are failing but not others. Let's see if the other changes resolve this failure as well.
goatshriek
added
enhancement
Adds required headers for free function. Move free inside loops to avoid memory leaks in test.
goatshriek
approved these changes
Jul 30, 2024
|
Thanks again! I've identified the issue affecting some of the builds - this will get merged once that makes it in so that this change doesn't falsely appear to cause failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds benchmarking for the function stumpless_get_prival_string. fixes #431