Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme Korean localization (|10n/ko-k0r/README.md) #463

Merged
merged 63 commits into from
Oct 7, 2024

Conversation

pmj-chosim
Copy link
Contributor

@pmj-chosim pmj-chosim commented Oct 7, 2024

Localization English Readme to Korean(|10n/ko-k0r/README.md).

and Like '|10n/zh-cn' folder, I made assest folder as Korean in '|10n/ko-kr'
image


*Question

Hello. I want to ask about localization.

  1. I didn’t translate linking words that are proper nouns or specific terms, such as Twitter hashtags, function names, or technical terms. For example, the #StumplessLib hashtag was left untranslated. Is it Okay?

  2. Translate about "Severity Shorthand"
    I translated "Severity Shorthand" to "로그 레벨(Severity) 단축 명령어," which means "Log Level Shorthand." I tried to find a proper word for "severity" in Korean. The direct translation is "심각도," but this term is not commonly used and could lead to misunderstandings. Therefore, I opted to use "로그 레벨." Is this approach acceptable?

  3. Location
    image

I put Chinese Readme > English Readme > [Key Features] | [Build and Install] | [Basic Usage | [Contributing](transltation these words in korean)
Is this location aceeptable?

@goatshriek goatshriek added the l10n localization of stumpless label Oct 7, 2024
@goatshriek goatshriek self-assigned this Oct 7, 2024
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.54%. Comparing base (1bd3333) to head (707e6a9).
Report is 4 commits behind head on latest.

Additional details and impacted files
@@            Coverage Diff             @@
##           latest     #463      +/-   ##
==========================================
+ Coverage   90.35%   90.54%   +0.19%     
==========================================
  Files          47       47              
  Lines        4374     4379       +5     
  Branches      586      587       +1     
==========================================
+ Hits         3952     3965      +13     
+ Misses        287      280       -7     
+ Partials      135      134       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@goatshriek goatshriek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, your approach here has been perfect! Thank you very much for contributing such a large translation, I'm sure it will make the project more accessible to a lot of people!

@goatshriek goatshriek merged commit 52b24fb into goatshriek:latest Oct 7, 2024
56 checks passed
@goatshriek goatshriek added the hacktoberfest-accepted accepted work that is valid for hacktoberfest label Oct 7, 2024
@pmj-chosim
Copy link
Contributor Author

Thank you:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted accepted work that is valid for hacktoberfest l10n localization of stumpless
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants