-
-
Notifications
You must be signed in to change notification settings - Fork 997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add AdventureLog Community Integration Documentation #12928
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for authentik-storybook canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @seanmorley15 ; Thanks for your contribution to authentik! I noticed a few things that would necessitate your review, once that's done I'll be happy to take another look at this PR. Please do let me know if you have any questions.
Hi @dominic-r, thanks so much for taking the time to review! I just made the changes you suggested. Let me know if there is anything else that should be changed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @seanmorley15 Thanks for your time. Here are some things I noticed in this second review. Nothing major, just some nit-picks. Thanks
|
||
The following placeholders are used in this guide: | ||
|
||
- `https://adventurelog.company` is the FQDN used to access the AdventureLog **server** instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- `https://adventurelog.company` is the FQDN used to access the AdventureLog **server** instance. | |
- `https://adventurelog.company` is the FQDN of the AdventureLog server installation. |
If that makes sense in this context
This documentation lists only the settings that you need to change from their default values. Be aware that any changes other than those explicitly mentioned in this guide could cause issues accessing your application. | ||
::: | ||
|
||
## authentik configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to tana: Will leave like this for the moment and fix during migration PR
- Name: authentik | ||
- Client ID: authentik Client ID | ||
- Secret Key: authentik Client Secret | ||
- Key: can be left blank |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be left blank or should be left blank? If users could/should put something here, could you detail the steps to do so?
|
||
### authentik - No Permission | ||
|
||
In the authentik instance, check access to the AdventureLog application from a specific user by using the Check Access/Test button on the Application dashboard. If the user doesn't have access, you can add an existing user/group policy to give your specific user/group access to the AdventureLog application. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add an introduction sentence to tell the user how to reach this step?
|
||
### 404 error when logging in. | ||
|
||
Ensure the `https://adventurelog.company/accounts` path is routed to the backend, as it shouldn't hit the frontend when it's properly configured. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's not routed to the backend, how is this error resolved? You could link existing service documentation to avoid detailing all the steps.
|
||
- Sites: move over the sites you want to enable authentik on, usually `example.com` and `www.example.com` unless you renamed your sites. | ||
|
||
4. Save the configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
t step 2 2? If i'm reading this correctly, you are passing from step 1 on line 58 to step 4 here.
cc @tanberry when you have a second for additional review / merge |
Details
Adds documentation for an AdventureLog community integration.
Checklist
make website
)