Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add AdventureLog Community Integration Documentation #12928

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

seanmorley15
Copy link

Details

Adds documentation for an AdventureLog community integration.


Checklist

  • The documentation has been updated
  • The documentation has been formatted (make website)

@seanmorley15 seanmorley15 requested a review from a team as a code owner February 3, 2025 23:48
Copy link

netlify bot commented Feb 3, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit da1686b
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/67a212654b57230008816b3f
😎 Deploy Preview https://deploy-preview-12928--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 3, 2025

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit da1686b
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/67a21265e56e7700086a7836

Copy link
Contributor

@dominic-r dominic-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @seanmorley15 ; Thanks for your contribution to authentik! I noticed a few things that would necessitate your review, once that's done I'll be happy to take another look at this PR. Please do let me know if you have any questions.

website/integrations/services/adventurelog/index.md Outdated Show resolved Hide resolved
website/integrations/services/adventurelog/index.md Outdated Show resolved Hide resolved
website/integrations/services/adventurelog/index.md Outdated Show resolved Hide resolved
website/integrations/services/adventurelog/index.md Outdated Show resolved Hide resolved
@seanmorley15
Copy link
Author

Hi @dominic-r, thanks so much for taking the time to review! I just made the changes you suggested. Let me know if there is anything else that should be changed!

Copy link
Contributor

@dominic-r dominic-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @seanmorley15 Thanks for your time. Here are some things I noticed in this second review. Nothing major, just some nit-picks. Thanks


The following placeholders are used in this guide:

- `https://adventurelog.company` is the FQDN used to access the AdventureLog **server** instance.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `https://adventurelog.company` is the FQDN used to access the AdventureLog **server** instance.
- `https://adventurelog.company` is the FQDN of the AdventureLog server installation.

If that makes sense in this context

This documentation lists only the settings that you need to change from their default values. Be aware that any changes other than those explicitly mentioned in this guide could cause issues accessing your application.
:::

## authentik configuration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to tana: Will leave like this for the moment and fix during migration PR

- Name: authentik
- Client ID: authentik Client ID
- Secret Key: authentik Client Secret
- Key: can be left blank
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be left blank or should be left blank? If users could/should put something here, could you detail the steps to do so?


### authentik - No Permission

In the authentik instance, check access to the AdventureLog application from a specific user by using the Check Access/Test button on the Application dashboard. If the user doesn't have access, you can add an existing user/group policy to give your specific user/group access to the AdventureLog application.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add an introduction sentence to tell the user how to reach this step?


### 404 error when logging in.

Ensure the `https://adventurelog.company/accounts` path is routed to the backend, as it shouldn't hit the frontend when it's properly configured.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's not routed to the backend, how is this error resolved? You could link existing service documentation to avoid detailing all the steps.


- Sites: move over the sites you want to enable authentik on, usually `example.com` and `www.example.com` unless you renamed your sites.

4. Save the configuration.
Copy link
Contributor

@dominic-r dominic-r Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

t step 2 2? If i'm reading this correctly, you are passing from step 1 on line 58 to step 4 here.

@dominic-r
Copy link
Contributor

cc @tanberry when you have a second for additional review / merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants