Handle loop statement comparison between two variables in loop unrolling #1590
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we only detected fixed-sized loops when the loop comparison was between a variable and a constant. However, we already found the last assignment to the variable being changed in the loop body, and thus, we have a function for finding the last assigned value.
This PR adds the functionality also to detect fixed loops when the loop condition compares variables by finding the last assignment for the other compared variable.
This PR was inspired by the following loop from the SV-COMP task
loops/invert_string-3.c
, which we were lucky to solve based on the old heuristics but cannot solve anymore due to the new, more conservative heuristic.This task has the case including a cast. I added another case that would handle similar conditions without a cast as a precaution.