Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Ruby 2.6 #243

Merged
merged 3 commits into from
Sep 4, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
validate:
strategy:
matrix:
ruby-version: ["2.6", "2.7", "3.0", "3.1", "3.2"]
ruby-version: ["2.7", "3.0", "3.1", "3.2"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.7 is also out of live right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah but this should still work with 2.7

runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion .ruby-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.2.1
3.2.2
33 changes: 21 additions & 12 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 1.18.0 - Sept 4, 2023

- Remove Ruby 2.6 support

## 1.17.0 - June 5, 2023

- Update BLZ data - BLZ_20230605
Expand Down Expand Up @@ -145,7 +149,7 @@

- Skipped 0.11.21
- Added national_id_length for CA IBANs to prevent segfault when building from
local details.
local details.

## 0.11.20 - October 18, 2018

Expand Down Expand Up @@ -217,54 +221,54 @@
- Fix `swift_national_id` for Slovenian IBANs. Previously it was
returning two digits, instead of five.

## 0.11.3 - March 9, 2017
## 0.11.3 - March 9, 2017

- Fix bug: Previously, constructing an `Ibandit::IBAN` object with
`country_code: "SE"` and certain 4-digit values for `account_number`
would throw `NoMethodError`. The IBAN object can now be successfully
constructed (and will return a false value for `valid?`).

## 0.11.2 - July 4, 2016
## 0.11.2 - July 4, 2016

- Handle invalid pseudo-IBANs

## 0.11.1 - June 6, 2016
## 0.11.1 - June 6, 2016

- Update BLZ data

## 0.11.0 - March 30, 2016
## 0.11.0 - March 30, 2016

- BREAKING CHANGE: Rename `IBAN#iban_national_id` to `IBAN#swift_national_id`.
See https://github.com/gocardless/ibandit/pull/69 for more details.

## 0.10.1 - March 7, 2016
## 0.10.1 - March 7, 2016

- Update BLZ data

## 0.10.0 - February 25, 2016
## 0.10.0 - February 25, 2016

- BREAKING CHANGE: Pass an `Ibandit::IBAN` object to modulus checker hooks,
rather than a string. See https://github.com/gocardless/ibandit/pull/68 for
more details.

## 0.9.1 - January 26, 2016
## 0.9.1 - January 26, 2016

- Update BLZ data

## 0.9.0 - January 25, 2016
## 0.9.0 - January 25, 2016

- BREAKING CHANGE: Update modulus checker hooks to expect a `valid_branch_code?`
method. See https://github.com/gocardless/ibandit/pull/65 for more details.

## 0.8.8 - January 22, 2016
## 0.8.8 - January 22, 2016

- Strip whitespace from Spanish account numbers

## 0.8.7 - December 8, 2015
## 0.8.7 - December 8, 2015

- Handle bad characters gracefully when constructing Italian IBANs

## 0.8.6 - December 6, 2015
## 0.8.6 - December 6, 2015

- Add details of Swedish validation scheme to Swedish data file
- Update BLZ data
Expand All @@ -286,20 +290,25 @@
- Update BLZ data

## 0.8.1 - August 14, 2015

- Clean SWIFT details

## 0.8.0 - August 14, 2015

- Return local details for Sweden
- Introduce pseudo-IBANs for Sweden

## 0.7.0 - August 11, 2015

- Remove all unused `CheckDigit` methods

## 0.6.6 - July 31, 2015

- Add Croatia to LocalDetailsCleaner and IBANAssembler
- Add Czech Republic to LocalDetailsCleaner and IBANAssembler

## 0.6.5 - July 30, 2015

- Add Romania to LocalDetailsCleaner and IBANAssembler
- Add Bulgaria to LocalDetailsCleaner and IBANAssembler
- Add Hungary to LocalDetailsCleaner and IBANAssembler
Expand Down
57 changes: 32 additions & 25 deletions ibandit.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -2,31 +2,38 @@

require File.expand_path("lib/ibandit/version", __dir__)

Gem::Specification.new do |gem|
gem.add_development_dependency "gc_ruboconfig", "~> 3.6.2"
gem.add_development_dependency "nokogiri", "~> 1.6"
gem.add_development_dependency "pry", "~> 0.13"
gem.add_development_dependency "pry-byebug", "~> 3.9"
gem.add_development_dependency "rspec", "~> 3.3"
gem.add_development_dependency "rspec-its", "~> 1.2"
gem.add_development_dependency "rspec_junit_formatter", "~> 0.6.0"
gem.add_development_dependency "sax-machine", "~> 1.3"
Gem::Specification.new do |spec|
spec.name = "ibandit"
spec.version = Ibandit::VERSION.dup
spec.summary = "Convert national banking details into IBANs, and vice-versa."
spec.description = <<~MSG.strip.tr("\n", " ")
Ibandit is a Ruby library for manipulating and
validating IBANs. It allows you to construct an IBAN
from national banking details; deconstruct an IBAN into
national banking details; and validate an IBAN's check
digits and format.
MSG
spec.authors = %w[GoCardless]
spec.email = %w[[email protected]]
spec.licenses = ["MIT"]

gem.add_runtime_dependency "i18n"
spec.files = `git ls-files`.split("\n")
spec.homepage = "https://github.com/gocardless/ibandit"

gem.authors = %w[GoCardless]
gem.description = "Ibandit is a Ruby library for manipulating and " \
"validating IBANs. It allows you to construct an IBAN " \
"from national banking details; deconstruct an IBAN into " \
"national banking details; and validate an IBAN's check " \
"digits and format."
gem.email = %w[[email protected]]
gem.files = `git ls-files`.split("\n")
gem.homepage = "https://github.com/gocardless/ibandit"
gem.licenses = ["MIT"]
gem.name = "ibandit"
gem.require_paths = ["lib"]
gem.summary = "Convert national banking details into IBANs, and vice-versa."
gem.version = Ibandit::VERSION.dup
gem.metadata["rubygems_mfa_required"] = "true"
spec.metadata = {
"rubygems_mfa_required" => "true",
}

spec.require_paths = ["lib"]

spec.required_ruby_version = ">= 2.7.0"
spec.add_development_dependency "gc_ruboconfig", "~> 4.3"
spec.add_development_dependency "nokogiri", "~> 1.6"
spec.add_development_dependency "pry", "~> 0.13"
spec.add_development_dependency "pry-byebug", "~> 3.10"
spec.add_development_dependency "rspec", "~> 3.12"
spec.add_development_dependency "rspec-its", "~> 1.2"
spec.add_development_dependency "sax-machine", "~> 1.3"

spec.add_runtime_dependency "i18n"
end
2 changes: 1 addition & 1 deletion lib/ibandit/version.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# frozen_string_literal: true

module Ibandit
VERSION = "1.17.0"
VERSION = "1.18.0"
end