Queue Depth functionality + Panic with Async #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WGH-
reviewed
Oct 17, 2023
| @@ -158,7 +158,7 @@ func (r *Request) Retry() error { | |||
|
|
|||
| // Do submits the request | |||
| func (r *Request) Do() error { | |||
| return r.collector.scrape(r.URL.String(), r.Method, r.Depth, r.Body, r.Ctx, *r.Headers, !r.collector.AllowURLRevisit) | |||
| return r.collector.scrape(r.URL.String(), r.Method, r.Depth+1, r.Body, r.Ctx, *r.Headers, !r.collector.AllowURLRevisit) | |||
There was a problem hiding this comment.
I don't understand this change. Could you please clarify? The test you added doesn't catch it if I revert this change.
There was a problem hiding this comment.
Odd, the TestCollectorDepth test should catch that, it's so that the depth increases on each request, so that you can use MaxDepth in Queue-based crawlers. I'll take a look at it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds support for Depth in Queue and adds a panic when attempting to use Async with Queue, as they are incompatible. The changes ensure that MaxDepth works as expected when using Queues.
I had to figure out by trial and error that Async caused my Queue based crawler to instantly finish since it thought the returned promises were 'completed' requests.
Changes Made
Depthfor Requests made inAddURL.AddRequestmethod to increase the depth for each nested request.Queue.Runmethod to prevent users from using Async with the Queue, as it's not supported.Checklist
Please let me know if you require any changes to this Pull Request!
And if there's any interest I did make a
UniqueInMemoryQueueStoragestruct in my project that only stores non duplicate entries within the Queue.Thank you!