Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor eglot-server-programs #157

Closed

Conversation

katomuso
Copy link
Contributor

@katomuso katomuso commented Nov 4, 2024

Using add-to-list is idiomatic when we want to add some value to the list if it isn’t there. Also, we don't need to (defvar eglot-server-programs) and gdscript-ts-mode should be there as well.

@katomuso
Copy link
Contributor Author

katomuso commented Nov 4, 2024

I guess I've misunderstood this bit of code. Probably, the intent was to push it at the beginning, so it will overwrite the default, whatever that is, so I'm closing this PR.

@katomuso katomuso closed this Nov 4, 2024
@katomuso katomuso deleted the refactor-eglot-server-programs branch November 5, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant