Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new rendering priorities post for January 2024 #780

Merged
merged 10 commits into from
Jan 16, 2024

Conversation

clayjohn
Copy link
Member

@clayjohn clayjohn commented Jan 9, 2024

This ended up a lot longer than I planned

@clayjohn clayjohn added the topic:blog New blogposts and corrections label Jan 9, 2024
Copy link
Collaborator

@JohnVeness JohnVeness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from my nitpicks :)

@clayjohn
Copy link
Member Author

@JohnVeness Thank you very much! I applied all your suggestions

Copy link
Collaborator

@JohnVeness JohnVeness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for merging all those. Just one more change, to use "Sentence case" rather than "Title Case" for headings, for consistency with other articles :)

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Co-authored-by: Rémi Verschelde <[email protected]>
@clayjohn
Copy link
Member Author

Thanks! I applied your suggestions

@MurderVeggie
Copy link
Collaborator

MurderVeggie commented Jan 15, 2024

Looks good to me, only thing I would suggest rephrasing is this line:

Please remember that this is merely a list of things that the rendering teams feels are priorities.

into

Please keep in mind that this is simply a list of things the rendering team deems a priority.

Reasoning:

  • merely makes it sound a little too negative/takes away from the effort that went into making this article
  • feels is a dangerous word to use, somehow it always leads to people questioning you

@akien-mga akien-mga merged commit c39df52 into godotengine:master Jan 16, 2024
1 check passed
@clayjohn clayjohn deleted the rendering-priorities-jan-2024 branch January 16, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic:blog New blogposts and corrections
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants