Fix lag when resizing Floating Game Window #102618
Merged
+8
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Feb 9, 2025
|
Will this fix the window stop rendering in wayland when out of focus? Screencast_20250209_220249.webm
|
|
This seems another issue not yet reported. Can you create a new separate bug for this issue with detailed version on your distribution and window manager? Thanks. |
akien-mga
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the frequency at which the update for the embedded process is performed. It is now executed again each time the floating window is resized or moved, significantly improving the user experience.
To avoid performing calculations on every frame and a deferred call, I retained the new timer to detect incorrectly focused windows/processes and mouse-over focus. These operations can be executed less frequently. The update for the embedded process now occurs in the
processnotification.I retested this on my old computer, and the difference is mostly unnoticeable.
Fedora 41 KDE Plasma - Godot 4.4 Beta 3:
Screencast_20250209_073251.webm
Fedora 41 KDE Plasma - Godot this PR:
Screencast_20250209_073125.webm