Fix NavBase properties not requesting sync #102754
Merged
+106
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiroxas
reviewed
Feb 12, 2025
Fixes that setters of NavBase properties never made the link or region dirty and requested a sync.
smix8
force-pushed
the
fix_navbase_dirty
branch
from
d33c195 to
98f5305
Compare
akien-mga
approved these changes
Feb 12, 2025
kiroxas
approved these changes
Feb 12, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that setters of NavBase properties never made the link or region dirty and requested a sync.
Fixes #102745
Frankly that the NavBase setters never made the link or region dirty was already questionable, it was just not creating an immediate problem. It was not a problem before because everything, for better or worse, was reading directly from the link or region pointer. Now it is reading from an iteration and without a sync request this iteration never gets updated and that caused the bug.