Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more defaults to generated files #70369

Closed
wants to merge 5 commits into from
Closed

add more defaults to generated files #70369

wants to merge 5 commits into from

Conversation

lesleyrs
Copy link

Hey so with Godot 4 being available soon I think a lot of new projects will be created and currently on Github there are a lot of gdscript project that show up as GAP incorrectly.

So I think it would be a good idea to just generate everything you would want so people don't have to bother with that at all. I just imitated the Godot engine .gitattributes I don't think there's any downsides besides adding some bytes.

I didn't touch the .gitignore because I'm unsure which are relevant for godot 4, but I think the following could be added?

# Imported translations (automatically generated from CSV files)
*.translation

# Mono-specific ignores
.mono/
data_*/
mono_crash.*.json

@Calinou Calinou added this to the 4.0 milestone Dec 20, 2022
@lesleyrs
Copy link
Author

lesleyrs commented Dec 20, 2022

Edit: nvm I misread your comment about bat files

Before merge which of these should be added to .gitignore, I haven't used mono build:

*.translation

# Mono-specific ignores
.mono/
data_*/
mono_crash.*.json

I guess @aaronfranke knows which apply to Godot 4 only?

Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess @aaronfranke knows which apply to Godot 4 only?

See #68295

editor/editor_vcs_interface.cpp Show resolved Hide resolved
editor/editor_vcs_interface.cpp Show resolved Hide resolved
editor/editor_vcs_interface.cpp Outdated Show resolved Hide resolved
@lesleyrs lesleyrs closed this Dec 20, 2022
@lesleyrs lesleyrs deleted the patch-1 branch December 21, 2022 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants