-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add more defaults to generated files #70369
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
reviewed
Dec 20, 2022
Calinou
reviewed
Dec 20, 2022
Calinou
reviewed
Dec 20, 2022
Co-authored-by: Hugo Locurcio <[email protected]>
Co-authored-by: Hugo Locurcio <[email protected]>
Co-authored-by: Hugo Locurcio <[email protected]>
Edit: nvm I misread your comment about bat files Before merge which of these should be added to .gitignore, I haven't used mono build:
I guess @aaronfranke knows which apply to Godot 4 only? |
aaronfranke
reviewed
Dec 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess @aaronfranke knows which apply to Godot 4 only?
See #68295
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey so with Godot 4 being available soon I think a lot of new projects will be created and currently on Github there are a lot of gdscript project that show up as GAP incorrectly.
So I think it would be a good idea to just generate everything you would want so people don't have to bother with that at all. I just imitated the Godot engine .gitattributes I don't think there's any downsides besides adding some bytes.
I didn't touch the .gitignore because I'm unsure which are relevant for godot 4, but I think the following could be added?