Add tests for control to test anchoring and minimum size #98757
Merged
+209
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
reviewed
Nov 2, 2024
Calinou
reviewed
Nov 2, 2024
girdenis-p
force-pushed
the
control-layout-tests
branch
from
e192ec5 to
512614e
Compare
99 tasks
Calinou
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
Code looks good to me.
Please rebase to fix merge conflicts. See PR workflow for instructions 🙂
girdenis-p
force-pushed
the
control-layout-tests
branch
from
512614e to
577ee91
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contributes to issue #43440.
I have added unit tests to check anchoring using the
set_anchorandset_offsetmethods for theControlnode. I have also added unit tests forset_custom_minimum_sizeand methods that set grow direction.For organisation purposes, I have also renamed a previously existing unnamed test case to help distinguish its purpose from the other test cases.