Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] fix(gwos-evm): correct ckb-c-stdlib git ref #880

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

keroro520
Copy link
Contributor

@keroro520 keroro520 commented Nov 29, 2022

https://github.com/TheWaWaR/ckb-c-stdlib/commits/master:

8510157885bb5db443bb13b50da5153a3dd1c39f is not found,
so I switch to the latest commit 6665e3a289648a0da69b818ea620aeb5e8d74e3b

@magicalne
Copy link
Contributor

You can find the commit here: TheWaWaR/ckb-c-stdlib@8510157

@keroro520
Copy link
Contributor Author

TheWaWaR/ckb-c-stdlib@8510157

There is a warning: This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

2022-11-29 at 11 33 AM

@magicalne
Copy link
Contributor

I guess this commit belongs to a tag and the branch was deleted. Didn't check -.-
If you have to make an upgrade, we need a full test to make sure this is safe.
I think it's good to leave this pr here as TODO.

@keroro520
Copy link
Contributor Author

I guess this commit belongs to a tag and the branch was deleted. Didn't check -.- If you have to make an upgrade, we need a full test to make sure this is safe. I think it's good to leave this pr here as TODO.

I upgrade it because that compiling gwos will fail with object not found - no match for id (8510157885bb5db443bb13b50da5153a3dd1c39f); class=Odb (9); code=NotFound (-3).

Full logs:

capsule build
Building contract state-validator
    Updating crates.io index
    Updating git repository `https://github.com/keroro520/godwoken.git`
    Updating git submodule `https://github.com/TheWaWaR/ckb-c-stdlib.git`
error: failed to get `gw-common` as a dependency of package `gw-utils v0.1.0 (/code/contracts/gw-utils)`

Caused by:
  failed to load source for dependency `gw-common`

Caused by:
  Unable to update https://github.com/keroro520/godwoken.git?rev=52ab220f163b88edea92998409bc6988d8a3b432

Caused by:
  failed to update submodule `gwos-evm/deps/ckb-c-stdlib`

Caused by:
  object not found - no match for id (8510157885bb5db443bb13b50da5153a3dd1c39f); class=Odb (9); code=NotFound (-3)
error: docker container exit with code Some(101)

@keroro520
Copy link
Contributor Author

keroro520 commented Nov 29, 2022

Thanks @TheWaWaR has pushed a branch fix-g++ containing TheWaWaR/ckb-c-stdlib@8510157

Leaving this PR as TODO as @magicalne suggested

@jjyr jjyr changed the title fix(gwos-evm): correct ckb-c-stdlib git ref [WIP] fix(gwos-evm): correct ckb-c-stdlib git ref Nov 29, 2022
@Flouse Flouse marked this pull request as draft December 4, 2022 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants