Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): govulncheck uses go.mod and use the correct notation from actions/setup-go #61

Merged
merged 3 commits into from
Sep 26, 2023

Conversation

ethanholz
Copy link
Contributor

Related to #60

@ethanholz
Copy link
Contributor Author

Looks like a different version of the action may be needed to make this work without warnings.

@taigrr
Copy link
Member

taigrr commented Sep 25, 2023

I'd like to use 1.21.1. Why are we setting it to 1.21?

@ethanholz
Copy link
Contributor Author

It seems that we were getting failures on the codeql analysis due to this. Reverting the go version ensures that this can run as expected. Furthermore, migrating the govulncheck to use go.mod will use the latest minor release of whatever is in the go.mod.

@taigrr
Copy link
Member

taigrr commented Sep 26, 2023

github/codeql#13992

They're claiming this should have been fixed a week ago, let's check the version of the runner instead of setting the go version to 1.21.

@taigrr
Copy link
Member

taigrr commented Sep 26, 2023

please remove ad5ca74 and I'll merge the other commit for now

@ethanholz
Copy link
Contributor Author

@taigrr looks like we are good to go and CodeQL is fixed as well!

@taigrr taigrr merged commit 9ad74d7 into gogrlx:master Sep 26, 2023
3 of 4 checks passed
@ethanholz ethanholz deleted the fix/govulncheck branch October 2, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants