add jobid to logger #19000
Closed
add jobid to logger #19000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #19000 +/- ##
==========================================
+ Coverage 67.40% 67.43% +0.03%
==========================================
Files 992 992
Lines 108725 108741 +16
Branches 2747 2747
==========================================
+ Hits 73286 73334 +48
+ Misses 31507 31473 -34
- Partials 3932 3934 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lengrongfu
force-pushed
the
feat/add-jobid-gclog
branch
2 times, most recently
from
52c96e1
to
af68ca5
Compare
|
/label release-note/enhancement |
lengrongfu
force-pushed
the
feat/add-jobid-gclog
branch
from
af68ca5
to
c1ed836
Compare
Append the signer name to the error message which will be returned by the client Signed-off-by: wang yan <[email protected]> Signed-off-by: lengrongfu <[email protected]>
lengrongfu
force-pushed
the
feat/add-jobid-gclog
branch
from
c1ed836
to
c5b29ed
Compare
|
commit error 😓 , close current pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
background:
When I view the gc job log from the ui, because my log has a lot of content, the loading is very slow, and I cannot view it in real time; therefore, I want to enter the jobserver pod to view the gc job log, but the log file is named after the job_id. I can't get job_id from ui.
solution:
In order to solve the problem of viewing the gc job, I think that the job_id can be output to the log file, so that the job_id can be viewed from the ui.
Issue being fixed
Fixes #(issue) #18999
Please indicate you've done the following: