Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up photon version from 4.0 to 5.0 #19006

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

YangJiao0817
Copy link
Member

@YangJiao0817 YangJiao0817 commented Jul 26, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@YangJiao0817 YangJiao0817 added area/build release-note/infra Infra related changes e.g. release, test, ship etc... labels Jul 26, 2023
@YangJiao0817 YangJiao0817 requested a review from a team as a code owner July 26, 2023 02:20
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #19006 (2b7b24d) into main (854e029) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19006      +/-   ##
==========================================
- Coverage   67.40%   67.40%   -0.01%     
==========================================
  Files         992      992              
  Lines      108748   108748              
  Branches     2749     2749              
==========================================
- Hits        73305    73301       -4     
- Misses      31510    31516       +6     
+ Partials     3933     3931       -2     
Flag Coverage Δ
unittests 67.40% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YangJiao0817 YangJiao0817 force-pushed the bump-up-photon-to-5 branch 2 times, most recently from 37ea9c8 to faf730c Compare July 31, 2023 03:29
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YangJiao0817 YangJiao0817 merged commit 5e130bd into goharbor:main Aug 1, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build release-note/infra Infra related changes e.g. release, test, ship etc... target/2.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants