fix accessory import issue #19053
Merged
fix accessory import issue #19053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes goharbor#19041 The issuse was introduced by goharbor#17087. To move the import to main since the anonymous imports only allowed at main in go-cilint. Fixes it: To add the anonymous imports at the jobservice main since the gc job needs to remove accessory when to delete an artifact Signed-off-by: wang yan <[email protected]>
wy65701436
assigned AllForNothing, zyyw and chlins and unassigned Vad1mo, stonezdj, chlins and AllForNothing
Codecov Report
@@ Coverage Diff @@
## main #19053 +/- ##
==========================================
- Coverage 70.57% 67.43% -3.15%
==========================================
Files 748 992 +244
Lines 95341 108727 +13386
Branches 0 2747 +2747
==========================================
+ Hits 67291 73319 +6028
- Misses 24426 31477 +7051
- Partials 3624 3931 +307
Flags with carried forward coverage won't be shown. Click here to find out more. |
zyyw
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19041
The issuse was introduced by #17087. To move the import to main since the anonymous imports only allowed at main in go-cilint.
Fixes it:
To add the anonymous imports at the jobservice main since the gc job needs to remove accessory when to delete an artifact
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: