Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes 19043 #19054

Merged
merged 3 commits into from
Jul 31, 2023
Merged

fixes 19043 #19054

merged 3 commits into from
Jul 31, 2023

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented Jul 28, 2023

fixes #19043
Skip the policy checking when to pull the notation signature

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #19054 (e0075ea) into main (638c26c) will increase coverage by 22.45%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #19054       +/-   ##
===========================================
+ Coverage   44.95%   67.41%   +22.45%     
===========================================
  Files         244      992      +748     
  Lines       13390   108738    +95348     
  Branches     2748     2748               
===========================================
+ Hits         6020    73309    +67289     
- Misses       7067    31495    +24428     
- Partials      303     3934     +3631     
Flag Coverage Δ
unittests 67.41% <100.00%> (+22.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/server/middleware/util/util.go 92.85% <100.00%> (ø)

... and 751 files with indirect coverage changes

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

fixes goharbor#19043
Skip the policy checking when to pull the notation signature

Signed-off-by: wang yan <[email protected]>
@zyyw zyyw changed the title fixes 19048 fixes 19043 Jul 31, 2023
@wy65701436 wy65701436 merged commit bef4ccc into goharbor:main Jul 31, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ignore-for-release Do not include PR or Issue for release notes target/2.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replication failed when Deployment security is set Notation
6 participants