Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cache for project policy updating #19068

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Aug 1, 2023

  1. Fixes Edited project config displayed incorrectly after saving #19065

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@AllForNothing AllForNothing requested a review from a team as a code owner August 1, 2023 05:19
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #19068 (1b7f37a) into main (5e130bd) will increase coverage by 22.52%.
The diff coverage is 20.00%.

❗ Current head 1b7f37a differs from pull request most recent head b1c0b77. Consider uploading reports for the commit b1c0b77 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #19068       +/-   ##
===========================================
+ Coverage   44.86%   67.38%   +22.52%     
===========================================
  Files         244      992      +748     
  Lines       13399   108751    +95352     
  Branches     2749     2749               
===========================================
+ Hits         6011    73280    +67269     
- Misses       7083    31540    +24457     
- Partials      305     3931     +3626     
Flag Coverage Δ
unittests 67.38% <20.00%> (+22.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ting-resolvers/project-routing-resolver.service.ts 17.39% <0.00%> (ø)
.../portal/src/app/shared/services/project.service.ts 4.25% <25.00%> (-0.30%) ⬇️

... and 752 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AllForNothing AllForNothing merged commit 28e6a99 into goharbor:main Aug 1, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edited project config displayed incorrectly after saving
6 participants