Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conformance test -- set referrers artifactType with actual type #19260

Closed

Conversation

MinerYang
Copy link
Contributor

@MinerYang MinerYang commented Aug 31, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #19259

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@MinerYang MinerYang requested a review from a team as a code owner August 31, 2023 04:51
@MinerYang MinerYang changed the title Fix conformance test -- set rfeferrers artifactType with actual type Fix conformance test -- set referrers artifactType with actual type Aug 31, 2023
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #19260 (22b249c) into main (c7e2529) will increase coverage by 3.18%.
Report is 13 commits behind head on main.
The diff coverage is 45.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19260      +/-   ##
==========================================
+ Coverage   67.39%   70.57%   +3.18%     
==========================================
  Files         993      749     -244     
  Lines      108888    95488   -13400     
  Branches     2751        0    -2751     
==========================================
- Hits        73382    67393    -5989     
+ Misses      31561    24456    -7105     
+ Partials     3945     3639     -306     
Flag Coverage Δ
unittests 70.57% <45.45%> (+3.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/controller/artifact/processor/default.go 70.83% <37.50%> (-0.60%) ⬇️
src/server/registry/referrers.go 68.14% <50.00%> (ø)
src/server/middleware/subject/subject.go 49.31% <100.00%> (ø)

... and 254 files with indirect coverage changes

@MinerYang
Copy link
Contributor Author

@MinerYang MinerYang closed this Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conformance test issue -- discovery test Oci-Filters-Applied should return filtertype
5 participants