-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update default processor for empty config & none-json config layer #19367
Closed
MinerYang
wants to merge
1
commit into
goharbor:main
from
MinerYang:fix-conformance-test-update-default-processor
Closed
update default processor for empty config & none-json config layer #19367
MinerYang
wants to merge
1
commit into
goharbor:main
from
MinerYang:fix-conformance-test-update-default-processor
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinerYang
force-pushed
the
fix-conformance-test-update-default-processor
branch
from
September 15, 2023 17:37
7d33bd2
to
576d050
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #19367 +/- ##
==========================================
- Coverage 70.63% 70.62% -0.02%
==========================================
Files 744 744
Lines 95272 95276 +4
==========================================
- Hits 67299 67289 -10
- Misses 24336 24355 +19
+ Partials 3637 3632 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
MinerYang
force-pushed
the
fix-conformance-test-update-default-processor
branch
3 times, most recently
from
September 18, 2023 06:00
d98005d
to
f17c3e5
Compare
wy65701436
reviewed
Sep 18, 2023
wy65701436
reviewed
Sep 18, 2023
MinerYang
force-pushed
the
fix-conformance-test-update-default-processor
branch
from
September 18, 2023 07:08
f17c3e5
to
c993197
Compare
fix misspell lint update put suject arifact header set fix comment format lint Signed-off-by: yminer <[email protected]> adjust comment details update knwon config type ExtraAttrs parser & UT
MinerYang
force-pushed
the
fix-conformance-test-update-default-processor
branch
from
September 18, 2023 07:09
c993197
to
582e09b
Compare
Will split into 2 PRs
|
Will close this PR since keep track in this PR #20030 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes
Please indicate you've done the following: