Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update default processor for empty config & none-json config layer #19367

Conversation

MinerYang
Copy link
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (4051b2b) 70.63% compared to head (582e09b) 70.62%.
Report is 156 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19367      +/-   ##
==========================================
- Coverage   70.63%   70.62%   -0.02%     
==========================================
  Files         744      744              
  Lines       95272    95276       +4     
==========================================
- Hits        67299    67289      -10     
- Misses      24336    24355      +19     
+ Partials     3637     3632       -5     
Flag Coverage Δ
unittests 70.62% <77.77%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/controller/artifact/abstractor.go 66.96% <100.00%> (+0.90%) ⬆️
src/server/middleware/subject/subject.go 49.31% <100.00%> (ø)
src/controller/artifact/processor/default.go 53.48% <60.00%> (-17.95%) ⬇️

... and 3 files with indirect coverage changes

@MinerYang MinerYang force-pushed the fix-conformance-test-update-default-processor branch 3 times, most recently from d98005d to f17c3e5 Compare September 18, 2023 06:00
@MinerYang MinerYang force-pushed the fix-conformance-test-update-default-processor branch from f17c3e5 to c993197 Compare September 18, 2023 07:08
fix misspell lint

update put suject arifact header set

fix comment format lint

Signed-off-by: yminer <[email protected]>

adjust comment details

update knwon  config type ExtraAttrs parser & UT
@MinerYang MinerYang force-pushed the fix-conformance-test-update-default-processor branch from c993197 to 582e09b Compare September 18, 2023 07:09
@MinerYang
Copy link
Contributor Author

Will split into 2 PRs

@MinerYang
Copy link
Contributor Author

Will close this PR since keep track in this PR #20030

@MinerYang MinerYang closed this Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants