Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix audit_id serial type to bigserial #19383

Closed

Conversation

lengrongfu
Copy link
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

orm: PostgreSQL change auto to bigserial. https://github.com/beego/beego/releases/tag/v2.1.2

so upgrade beego version.

Issue being fixed

Fixes #(issue) #19302

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #19383 (1ec205e) into main (d0322df) will decrease coverage by 22.62%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #19383       +/-   ##
===========================================
- Coverage   67.45%   44.83%   -22.62%     
===========================================
  Files         988      244      -744     
  Lines      108732    13416    -95316     
  Branches     2752     2752               
===========================================
- Hits        73340     6015    -67325     
+ Misses      31446     7094    -24352     
+ Partials     3946      307     -3639     
Flag Coverage Δ
unittests 44.83% <ø> (-22.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 747 files with indirect coverage changes

@lengrongfu lengrongfu changed the title bump beego version fix audit_id serial type to bigserial Sep 22, 2023
@zyyw
Copy link
Contributor

zyyw commented Sep 25, 2023

@lengrongfu please fix the failed CI first. Thanks

@lengrongfu lengrongfu force-pushed the bump/upgrade-beego-version branch 11 times, most recently from 8118bf1 to 71586fd Compare October 4, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants