Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance the replication webhook payload #19433

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

chlins
Copy link
Member

@chlins chlins commented Oct 11, 2023

Add the new filed 'references' to the replication webhook payload, which can help user better know the replicated artifact tags or digests. (references is the lists of the artifact tag name or digest if no tag)

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #19035

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@chlins chlins added release-note/enhancement Label to mark PR to be added under release notes as enhancement target/2.10.0 labels Oct 11, 2023
@chlins chlins requested a review from a team as a code owner October 11, 2023 02:31
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #19433 (ac18fed) into main (322dce5) will increase coverage by 0.02%.
The diff coverage is 55.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19433      +/-   ##
==========================================
+ Coverage   67.46%   67.48%   +0.02%     
==========================================
  Files         988      988              
  Lines      108743   108770      +27     
  Branches     2752     2752              
==========================================
+ Hits        73361    73401      +40     
+ Misses      31428    31413      -15     
- Partials     3954     3956       +2     
Flag Coverage Δ
unittests 67.48% <55.17%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/controller/replication/execution.go 67.77% <100.00%> (+0.18%) ⬆️
src/controller/replication/flow/copy.go 43.87% <50.00%> (+0.57%) ⬆️
src/controller/replication/flow/deletion.go 49.12% <50.00%> (+0.90%) ⬆️
...ller/event/handler/webhook/artifact/replication.go 46.62% <0.00%> (-0.58%) ⬇️
src/controller/replication/flow/stage.go 69.28% <59.09%> (-1.72%) ⬇️

... and 9 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Add the new filed 'references' to the replication webhook payload, which
can help user better know the replicated artifact tags or digests.
(references is the lists of the artifact tag name or digest if no tag)

Signed-off-by: chlins <[email protected]>
@chlins chlins force-pushed the enhance/replication-webhook-payload branch from 34dcad3 to ac18fed Compare October 23, 2023 02:34
@chlins chlins enabled auto-merge (squash) October 23, 2023 02:36
@chlins chlins merged commit 99b40bf into goharbor:main Oct 23, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/enhancement Label to mark PR to be added under release notes as enhancement target/2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"How to identify the completion of image transmission with a specific tag within a webhook?"
5 participants