-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move strong_ssl_ciphers to top level in harbor.yml #19914
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19914 +/- ##
==========================================
- Coverage 67.45% 67.45% -0.01%
==========================================
Files 996 996
Lines 109773 109773
Branches 2720 2720
==========================================
- Hits 74044 74043 -1
- Misses 31747 31750 +3
+ Partials 3982 3980 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
2ca3b76
to
74c8eb1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we take care of these two parts as well
0b0a19d
to
daf66c2
Compare
Updated, just need to migrate the 2.10 |
2fd0e7e
to
45a5c80
Compare
d111e62
to
8aafe07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
d4c23df
to
a94bbd6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
fixes goharbor#19912 Signed-off-by: stonezdj <[email protected]>
a94bbd6
to
0b7c699
Compare
fixes #19912
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: