Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick]Limit URL to local site #20024

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Feb 23, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.70%. Comparing base (c097e4c) to head (6525e44).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-2.8.0   #20024   +/-   ##
==============================================
  Coverage          44.69%   44.70%           
==============================================
  Files                235      235           
  Lines              13091    13091           
  Branches            2671     2671           
==============================================
+ Hits                5851     5852    +1     
+ Misses              6947     6945    -2     
- Partials             293      294    +1     
Flag Coverage Δ
unittests 44.70% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: stonezdj <[email protected]>
@stonezdj stonezdj enabled auto-merge (squash) February 26, 2024 09:10
@stonezdj stonezdj merged commit cc32816 into goharbor:release-2.8.0 Feb 26, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants