Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove slack notification #21185

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

MinerYang
Copy link
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@MinerYang MinerYang added the release-note/ignore-for-release Do not include PR or Issue for release notes label Nov 14, 2024
@MinerYang MinerYang requested a review from a team as a code owner November 14, 2024 03:19
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.22%. Comparing base (c8c11b4) to head (34a96fe).
Report is 327 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21185      +/-   ##
==========================================
+ Coverage   45.36%   46.22%   +0.85%     
==========================================
  Files         244      247       +3     
  Lines       13333    13863     +530     
  Branches     2719     2867     +148     
==========================================
+ Hits         6049     6408     +359     
- Misses       6983     7118     +135     
- Partials      301      337      +36     
Flag Coverage Δ
unittests 46.22% <ø> (+0.85%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 491 files with indirect coverage changes

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MinerYang MinerYang merged commit d39d979 into goharbor:main Nov 14, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ignore-for-release Do not include PR or Issue for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants