Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adding missing argument for $sliceSelectedTextContent #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: adding missing argument for $sliceSelectedTextContent #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/lexical-selection/src/lexical-node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export function $sliceSelectedTextNodeContent(
textNode: TextNode,
): LexicalNode {
if (
textNode.isSelected() &&
textNode.isSelected(selection) &&
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We planning to upstream this fix into the lexical community package?

Copy link
Collaborator Author

@nadine-nguyen nadine-nguyen Dec 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we are - I just wanted approval from one of our team members first 😄

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

facebook#5380

!textNode.isSegmented() &&
!textNode.isToken() &&
$INTERNAL_isPointSelection(selection)
Expand Down